Repository navigation
4.x: Isolate FutureObserver race tests - #8394
Merged
Merged
Conversation
akarnokd
approved these changes
Nov 17, 2026
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.657 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8394 +/- ##
============================================
- Coverage 98.66% 98.62% -0.04%
+ Complexity 7172 7170 -2
============================================
Files 826 826
Lines 50972 50972
Branches 6944 6944
============================================
- Hits 50290 50270 -20
- Misses 466 475 +9
- Partials 216 227 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jimi-21
marked this pull request as ready for review
November 17, 2026 09:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #8075.
Move these
TestHelper.racetests fromFutureObserverTestintoFutureObserverIsolatedTest, following the requested naming pattern:cancelRaceonErrorCancelRaceonCompleteCancelRacecancelOnSubscribeRaceAll method bodies, loop counts, operations, assertions, and plugin error-handling cleanup are retained verbatim. This batch contains 2 test-file changes (+98/-69) and no production-code changes.
Verification
Using Zulu 26.0.2.1 and Gradle 9.9.0:
checkstyleTestpassed.AI disclosure: Kimi Code was used to prepare the changes, run local checks, and draft this PR description. Every moved method and the final diff were checked against the upstream originals.